Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert about changing content root #26372

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Add alert about changing content root #26372

merged 3 commits into from
Oct 5, 2021

Conversation

IEvangelist
Copy link
Member

Summary

Add alert about changing content root from binpath arg.

Fixes #26274

@IEvangelist IEvangelist requested a review from a team as a code owner October 4, 2021 19:18
@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 4, 2021
@IEvangelist IEvangelist requested a review from tdykstra October 4, 2021 19:26
tdykstra
tdykstra approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion.

docs/core/extensions/windows-service.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist enabled auto-merge (squash) October 5, 2021 12:37
@IEvangelist IEvangelist merged commit b362427 into dotnet:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Correct creation command in "Create a Windows Service using BackgroundService"
3 participants
@IEvangelist @tdykstra @dotnet-bot